Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(op_crates/web): TextEncoder error message with original input #8005

Merged
merged 1 commit into from
Oct 20, 2020
Merged

fix(op_crates/web): TextEncoder error message with original input #8005

merged 1 commit into from
Oct 20, 2020

Conversation

aca
Copy link
Contributor

@aca aca commented Oct 17, 2020 •
edited by bartlomieju
Loading

Instead of modifying input, return error message with original input.
Edited original test case for TextDecoder a little.

Closes #8003

@CLAassistant
Copy link

CLAassistant commented Oct 17, 2020 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@bartlomieju bartlomieju changed the title fix(op_crates/web): return error message with original input (#8003) fix(op_crates/web): TextEncoder error message with original input Oct 20, 2020
bartlomieju
bartlomieju approved these changes Oct 20, 2020
View reviewed changes
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @aca

@bartlomieju bartlomieju merged commit 9cf06f7 into denoland:master Oct 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bartlomieju bartlomieju bartlomieju approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TextDecoder converts string to lower case before throwing error
3 participants
@aca @CLAassistant @bartlomieju