fix(cli): use rid getter for stdio #8014
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This changes the rid of Deno.stdin, Deno.stdout, Deno.stderr from a mutable property into a getter to match the rid semantics of Deno.File.
bartlomieju
reviewed
Oct 19, 2020
Comment on lines
+713
to
+717
| export const stdin: Reader & ReaderSync & Closer & { readonly rid: number }; | ||
| /** A handle for `stdout`. */ | ||
| export const stdout: Writer & WriterSync & Closer & { rid: number }; | ||
| export const stdout: Writer & WriterSync & Closer & { readonly rid: number }; | ||
| /** A handle for `stderr`. */ | ||
| export const stderr: Writer & WriterSync & Closer & { rid: number }; | ||
| export const stderr: Writer & WriterSync & Closer & { readonly rid: number }; |
There was a problem hiding this comment.
Technically, yes but I don't think we ever intended for them to actually be mutable.
There was a problem hiding this comment.
@caspervonb that's true, I'm only afraid it's gonna cause type checking havoc, hopefully not many users access rid of stdio objects.
There was a problem hiding this comment.
Access should be fine - it should only break if someone tries to update it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the rid of Deno.stdin, Deno.stdout, Deno.stderr from a mutable property into a getter to match the rid semantics of Deno.File.