Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(op_crates/web): Change TypeError to RangeError #8039

Merged
merged 2 commits into from
Oct 19, 2020
Merged

fix(op_crates/web): Change TypeError to RangeError #8039

merged 2 commits into from
Oct 19, 2020

Conversation

gr7d
Copy link
Contributor

@gr7d gr7d commented Oct 19, 2020

Throw the same error type as Chromium does.
Discussed in #8003.

@gr7d
fix(op_crates/web): Change TypeError to RangeError
dac865f 
Set the same error type as in Chromium.
@CLAassistant
Copy link

CLAassistant commented Oct 19, 2020 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@bartlomieju
Copy link
Member

@l2ig thanks for the contribution, please sign the CLA and add a test case exercising this fix.

bartlomieju
bartlomieju approved these changes Oct 19, 2020
View reviewed changes
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nicely done, thanks @l2ig

@bartlomieju bartlomieju merged commit 623ac9e into denoland:master Oct 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bartlomieju bartlomieju bartlomieju approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@gr7d @CLAassistant @bartlomieju