Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(cli): rewrite Deno.transpileOnly() to use SWC #8090

Merged
merged 11 commits into from
Oct 26, 2020
Merged

refactor(cli): rewrite Deno.transpileOnly() to use SWC #8090

merged 11 commits into from
Oct 26, 2020

Conversation

bartlomieju
Copy link
Member

@bartlomieju bartlomieju commented Oct 23, 2020 •
edited
Loading

Closes #8059

kitsonk
kitsonk reviewed Oct 24, 2020
View reviewed changes
cli/ops/runtime_compiler.rs Outdated Show resolved Hide resolved
cli/tsc_config.rs Outdated Show resolved Hide resolved
cli/tsc_config.rs Outdated Show resolved Hide resolved
@kitsonk
Copy link
Contributor

kitsonk commented Oct 26, 2020

Ok, I made an attempt to address things. Let me know if you like it @bartlomieju.

@bartlomieju @kitsonk
Update cli/ops/runtime_compiler.rs
5d10aa0 
Co-authored-by: Kitson Kelly <me@kitsonkelly.com>
@bartlomieju
Copy link
Member Author

Ok, I made an attempt to address things. Let me know if you like it @bartlomieju.

@kitsonk LGTM, I think we achieved major goal of this PR which was migrating Deno.transpileOnly() API to SWC. All the rest can be addressed in follow ups

@bartlomieju bartlomieju requested a review from ry October 26, 2020 11:55
ry
ry approved these changes Oct 26, 2020
View reviewed changes
Copy link
Member

@ry ry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bartlomieju bartlomieju merged commit 57cad53 into denoland:master Oct 26, 2020
@bartlomieju bartlomieju deleted the runtime_transpile_refactor branch October 26, 2020 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kitsonk kitsonk kitsonk left review comments

@ry ry ry approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Migrate Deno.transpileOnly to new tsc/module_graph
3 participants
@bartlomieju @kitsonk @ry