Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(cli/permissions): Cleanup Flags to Permissions conversion #8213

Merged
merged 1 commit into from Oct 31, 2020
Merged

refactor(cli/permissions): Cleanup Flags to Permissions conversion #8213

merged 1 commit into from Oct 31, 2020

Conversation

nayeemrmn
Copy link
Collaborator

Remove unused/illogical From implementations on PermissionState. It also seems like UnaryPermissions::global_state was mistakenly renamed to program_state.

bartlomieju
bartlomieju approved these changes Oct 31, 2020
View reviewed changes
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bartlomieju bartlomieju merged commit d9b8778 into denoland:master Oct 31, 2020
@nayeemrmn nayeemrmn deleted the permissions-cleanup branch November 2, 2020 03:14
jannes pushed a commit to jannes/deno that referenced this pull request Dec 1, 2020
@nayeemrmn @jannes
refactor(cli/permissions): Cleanup Flags to Permissions conversion (d…
6e1a2eb 
…enoland#8213)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bartlomieju bartlomieju bartlomieju approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nayeemrmn @bartlomieju