Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(tools): add documentation for deno compile cmd #8615

Merged
merged 6 commits into from
Dec 5, 2020

Conversation

fabiante
Copy link
Contributor

@fabiante fabiante commented Dec 4, 2020

This PR adds documentation for the new deno compile command introduced in PR #8539 and discussed in #986

@CLAassistant
Copy link

CLAassistant commented Dec 4, 2020

CLA assistant check
All committers have signed the CLA.

@fabiante
Copy link
Contributor Author

fabiante commented Dec 4, 2020

@lucacasonato I figure you may be the correct person to review this. Please excuse me if not or I am unintentionally spamming.

@bartlomieju
Copy link
Member

Thanks @fabiante, make sure to run tools/format.js and tools/lint.js to make CI pass

@fabiante
Copy link
Contributor Author

fabiante commented Dec 4, 2020

Hi Bartek, I'd love to. Turns out in my local project third_party is empty, dprint therefore can't be called and I don't know how to fix that. I tried building Deno myself, hoping that would populate the given folder but it doesn't. I guess I am missing something very obvious here? Sorry to bother.

@bartlomieju
Copy link
Member

@fabiante you need to check out git submodules, following command should do the trick: git submodule update --init --recursive

Copy link
Member

@ry ry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks - please update docs/toc.json too

Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you @fabiante!

@bartlomieju bartlomieju merged commit 2d5c742 into denoland:master Dec 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants