Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(runtime): use tokio for async fs ops #9042

Merged
merged 6 commits into from Jan 8, 2021
Merged

fix(runtime): use tokio for async fs ops #9042

merged 6 commits into from Jan 8, 2021

Conversation

caspervonb
Copy link
Contributor

@caspervonb caspervonb commented Jan 7, 2021 •
edited

This makes the following ops async:

  • op_fstat_async
  • op_ftruncate_async
  • op_seek_async
  • op_fdatasync_async
  • op_fsync_async
  • op_futime_async

Fixes #7400

@caspervonb caspervonb marked this pull request as ready for review January 7, 2021 20:57
bnoordhuis
bnoordhuis approved these changes Jan 7, 2021
View reviewed changes
Copy link
Contributor

@bnoordhuis bnoordhuis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd try to factor out the repetitious code but LGTM either way.

runtime/ops/fs.rs Show resolved Hide resolved
@bartlomieju bartlomieju merged commit 9cf82d3 into denoland:master Jan 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bnoordhuis bnoordhuis bnoordhuis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

various async fs ops are not actually async
3 participants
@caspervonb @bnoordhuis @bartlomieju