Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update (cli/tests/wpt.jsonc): Added working wpt wasm tests #9072

Merged
merged 7 commits into from Jan 17, 2021
Merged

update (cli/tests/wpt.jsonc): Added working wpt wasm tests #9072

merged 7 commits into from Jan 17, 2021

Conversation

vishalvibes
Copy link
Contributor

Helps with issue #9001
I have added wasm wpt tests that were passing

@ry ry requested a review from lucacasonato January 10, 2021 16:25
@lucacasonato
Copy link
Member

@Vishal19111999 Can you also add all tests that don't pass, and comment them out? That way we know what we still need to get working.

@vishalvibes
Copy link
Contributor Author

@lucacasonato ok

@vishalvibes
Copy link
Contributor Author

@lucacasonato done

lucacasonato
lucacasonato approved these changes Jan 16, 2021
View reviewed changes
Copy link
Member

@lucacasonato lucacasonato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@lucacasonato lucacasonato merged commit 271fbe3 into denoland:master Jan 17, 2021
@vishalvibes vishalvibes deleted the add-wpt-wasm branch January 19, 2021 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucacasonato lucacasonato lucacasonato approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@vishalvibes @lucacasonato @bartlomieju