Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(lsp): add references code lens #9316

Merged
merged 5 commits into from
Feb 1, 2021
Merged

Conversation

kitsonk
Copy link
Contributor

@kitsonk kitsonk commented Jan 29, 2021

This add the infrastructure for providing code lenses in the LSP and adds the ability to display a lens for references for symbols in the code that aligns to the built-in functionality for TypeScript in VSCode.

I need to add an integration test for this feature.

cli/lsp/config.rs Outdated Show resolved Hide resolved
cli/lsp/config.rs Show resolved Hide resolved
cli/lsp/config.rs Show resolved Hide resolved
cli/lsp/language_server.rs Outdated Show resolved Hide resolved
cli/lsp/tsc.rs Show resolved Hide resolved
cli/lsp/analysis.rs Outdated Show resolved Hide resolved
@kitsonk
Copy link
Contributor Author

kitsonk commented Jan 31, 2021

Ok, I added docs in a few places where there were non-obvious reasons for things.

Copy link
Member

@ry ry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kitsonk kitsonk merged commit 534531e into denoland:master Feb 1, 2021
@kitsonk kitsonk mentioned this pull request Feb 1, 2021
43 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants