feat(lsp): add implementations code lens #9441
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kitsonk
commented
Feb 8, 2021
lucacasonato
approved these changes
Feb 8, 2021
There was a problem hiding this comment.
Implementation looks good to me. I tried this locally, and it works as expected.
Unrelated to this PR, I did find some weird alignment issues with the goto underlines when hovering over something in VS Code while holding the Ctrl key. Unsure if this is our fault or if it is a VS Code bug.
ctrl-broken.mp4
Those are different, I noticed them too and was going to investigate them. We should open an issue. |
Sure. I'll do that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires a client that provides a configuration with the
codeLens.implementationsset totrue(e.g. denoland/vscode_deno#319)