chore: bump Rust and cargo update #735
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
6 tasks
Closed
mmastrac
commented
May 10, 2024
| // SAFETY: transerialization assumptions imply `T` is still alive. | ||
| let x: &mut T = unsafe { opaque_deref_mut(self.opaque) }; | ||
| let x: &T = |
There was a problem hiding this comment.
This was not only unsafe, but UB -- we turned a ref into a pointer into a u64 into a &mut.
nathanwhit
approved these changes
May 10, 2024
mmastrac
added a commit
to denoland/deno
that referenced
this pull request
May 10, 2024
Includes a Rust 1.78.0 fix: denoland/deno_core#735 Fixes deno homebrew crashes: #23767 #23766 #23763 and Homebrew/homebrew-core#171317
dsherret
pushed a commit
to denoland/deno
that referenced
this pull request
May 10, 2024
Includes a Rust 1.78.0 fix: denoland/deno_core#735 Fixes deno homebrew crashes: #23767 #23766 #23763 and Homebrew/homebrew-core#171317
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We bump Rust to 1.78, but for the tests to pass we need to remove the UB that we've been relying on:
&mutfrom a u64 that comes from a&(UB)Lots of sketchiness left in serde_v8 but hopefully this fixes the major fire.
serde_v8 is considered deprecated so we're likely not going to touch this code much more than this band-aid.