-
-
Notifications
You must be signed in to change notification settings - Fork 12.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deno 1.43.2 homebrew build segmentation fault #171317
Comments
Minimal repro:
|
|
The only difference I can see is that we updated Rust to 1.78.0 in the interim. Perhaps Deno has issues with Rust 1.78? We don't ship Rust 1.77 anymore so will need to figure out a fix for 1.78 if so. |
We're unfortunately I'm not sure but we might be able to build Mac on 1.78 and Linux on 1.77 for now to see if it repros on our end. |
You mean 1.77, right? |
the downgrade to 1.43.1 works fine for me (with the
also I can reproduce this with deno 1.43.2, but not with deno 1.43.1
|
No, we can't upgrade to 1.78 for Linux builds because our sysroot build fails using the llvm-17 package we install from apt.llvm.org. Bug is here: denoland/deno#23676 Upstream LLVM issue here: llvm/llvm-project#87553 |
I found some UB in deno_core that is likely causing this. Rust 1.78 seems to have been the trigger for it to start failing, but the code was certainly busted for a while. This should be fixed in 1.43.3. |
That's what you mean but wrote 1.78 (typo) ;). Nevermind, explanations are clear. |
As a workaround: brew tap --force homebrew/core
cd "$(brew --repository homebrew/core)"
git checkout bf2314dc93067e2c6dd108279244ac3740b568e6
HOMEBREW_NO_INSTALL_FROM_API=1 brew install deno
git checkout master
# skip the command below if you contribute to homebrew/core
brew untap homebrew/core |
Not quite fixed yet. Merged PR is merely a workaround. |
Here's what appears to be happening:
We're going to fix the UB here by boxing the values. It's a band-aid fix but we consider this code to be EOL and we're actively working on replacing it. |
Includes a Rust 1.78.0 fix: denoland/deno_core#735 Fixes deno homebrew crashes: #23767 #23766 #23763 and Homebrew/homebrew-core#171317
Includes a Rust 1.78.0 fix: denoland/deno_core#735 Fixes deno homebrew crashes: #23767 #23766 #23763 and Homebrew/homebrew-core#171317
Deno 1.43.3 incoming -- should fix this issue. |
The deno formula downgrade to 1.43.1 is not installed over installed 1.43.2 formula:
|
Yes, #171382 was just meant to prevent more users from upgrading to a broken build. If you've already done so, you need to do |
Should be fixed in #171423 which will merge shortly. Do |
brew gist-logs <formula>
link ORbrew config
ANDbrew doctor
outputVerification
brew doctor
output saysYour system is ready to brew.
and am still able to reproduce my issue.brew update
and am still able to reproduce my issue.brew doctor
and that did not fix my problem.What were you trying to do (and why)?
The code in https://github.com/poolifier/poolifier-web-worker/tree/master/examples/deno/typescript segfault with Deno homebrew build version 1.43.2:
[1] 30111 segmentation fault deno run -A pool.ts
All UTs instantiating a pool are also triggering a segfault.
Deno homebrew build version 1.43.1 and official Deno.com binaries works fine.
What happened (include all command output)?
N/A
What did you expect to happen?
N/A
Step-by-step reproduction instructions (by running
brew
commands)The text was updated successfully, but these errors were encountered: