Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(feat) Support TS parameter properties #196

Closed
wants to merge 5 commits into from

Conversation

LionC
Copy link

@LionC LionC commented Oct 4, 2021

Closes #192

@CLAassistant
Copy link

CLAassistant commented Oct 4, 2021

CLA assistant check
All committers have signed the CLA.

@kitsonk kitsonk self-requested a review October 4, 2021 09:15
@kitsonk
Copy link
Contributor

kitsonk commented Oct 4, 2021

Thank you. As I stated in #192 (comment) though, I don't think this should generate a class property node. It should just be adding the accessibility value to the arguments on a constructor function.

@LionC
Copy link
Author

LionC commented Oct 4, 2021

I though the purpose of deno doc is to document a module's API? Whether a property is a parameter property or not is an implementation detail - it is actually completely opaque during runtime, as param properties do not exist in JS, which would make the doc output weird to JS users as well.

The property being noted in a completely different place in the docs due to how the module author implemented it internally feels strange to me.

EDIT: Read your new comment in the issue, will answer there :-)

@bartlomieju
Copy link
Member

Please rebase against main, I've updated the CI script and it should make ubuntu step pass

@kitsonk
Copy link
Contributor

kitsonk commented Jul 26, 2022

Thanks for this but closed in favour of #267

@kitsonk kitsonk closed this Jul 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Parameter properties are ignored
4 participants