feat: support TypeScript constructor params #267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kitsonk
force-pushed
the
feat_ts_ctor_params
branch
from
d090944
to
8e237c9
Compare
dsherret
approved these changes
Jul 26, 2022
| @@ -95,13 +95,19 @@ export interface ClassDef { | |||
| decorators?: DecoratorDef[]; | |||
| } | |||
|
|
|||
| export type ClassConstructorParamDef = ParamDef & { | |||
There was a problem hiding this comment.
Nitpick: seems more consistent to use an interface?
There was a problem hiding this comment.
You can't here, because ParamDef is a tagged union type alias and interfaces can't extend type aliases.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #192
This is an alternative to #196. Like the recent has_body change, instead of inferring, the doc nodes returned more reflect the code as written, and it is up to the printers to determine how to display that to the user.
In this situation, printers need to decide how to display a
publicconstructor param, along with the other accessibility keywords, override and readonly, which is to likely reflect them in the constructor signature as well as the properties documented on the class.