Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: publish to JSR #556

Merged
merged 6 commits into from
Apr 24, 2024
Merged

chore: publish to JSR #556

merged 6 commits into from
Apr 24, 2024

Conversation

iuioiua
Copy link
Contributor

@iuioiua iuioiua commented Apr 23, 2024 •
edited
Loading

deno publish --dry-run --allow-dirty passes fine here.

Instructions by an admin of this repo need to be followed: https://jsr.io/@deno/doc/publish

@crowlKats crowlKats requested a review from dsherret April 23, 2024 09:45
dsherret
dsherret reviewed Apr 23, 2024
View reviewed changes
.github/workflows/ci.yml Outdated Show resolved Hide resolved
dsherret
dsherret reviewed Apr 23, 2024
View reviewed changes
.github/workflows/ci.yml Outdated Show resolved Hide resolved
dsherret
dsherret approved these changes Apr 23, 2024
View reviewed changes
Copy link
Member

@dsherret dsherret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@dsherret dsherret enabled auto-merge (squash) April 24, 2024 15:44
@dsherret dsherret merged commit 556a3af into denoland:main Apr 24, 2024
4 checks passed
@dsherret
Copy link
Member

dsherret commented Apr 24, 2024 •
edited
Loading

Seems like a bug in deno publish --dry-run not catching this: https://github.com/denoland/deno_doc/actions/runs/8819506227/job/24210877646 (the gitignored files need to be unexcluded like this: https://github.com/denoland/deno_graph/blob/808cb47cb498c4e6a3984163fb56e05ec4d285ef/js/deno.json#L10-L12)

@dsherret
Copy link
Member

Opened denoland/deno#23540

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsherret dsherret dsherret approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@iuioiua @dsherret