Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(publish): --dry-publish should error for gitignored excluded files #23540

Merged
merged 3 commits into from
Apr 24, 2024
Merged

fix(publish): --dry-publish should error for gitignored excluded files #23540

merged 3 commits into from
Apr 24, 2024

Conversation

dsherret
Copy link
Member

@dsherret dsherret commented Apr 24, 2024 •
edited
Loading

Files that were gitignored only were not included in the diagnostic.

@dsherret dsherret mentioned this pull request Apr 24, 2024
Merged
dsherret
dsherret commented Apr 24, 2024
View reviewed changes
cli/tools/registry/mod.rs Outdated Show resolved Hide resolved
@dsherret dsherret marked this pull request as ready for review April 24, 2024 18:14
@dsherret dsherret enabled auto-merge (squash) April 24, 2024 18:44
@dsherret dsherret merged commit ded6afc into denoland:main Apr 24, 2024
17 of 20 checks passed
@dsherret dsherret deleted the fix_publish_error_gitignored_files_dry_publish branch April 24, 2024 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bartlomieju bartlomieju bartlomieju approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dsherret @bartlomieju