wasm: allow custom init path/url for the wasm binary #199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
I think we'll need to update to use serde-wasm-bindgen. @deckchairlabs are you willing to update to that? Otherwise I can take it on. |
Do you just want the dependency updated? If so I can update the PR |
|
It's ok! I updated the code so the CI would pass. Merging this now. |
|
Excellent! Will await the release |
|
I just kicked one off for you. Will be available once the CI runs finish. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #198
Updated the build task in
deno.jsonto use the latest wasmbuild. Builds successfully and tests pass locally.