-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
wasm: allow custom init path/url for the wasm binary #199
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks!
I think we'll need to update to use serde-wasm-bindgen. @deckchairlabs are you willing to update to that? Otherwise I can take it on. |
Do you just want the dependency updated? If so I can update the PR |
It's ok! I updated the code so the CI would pass. Merging this now. |
Excellent! Will await the release |
I just kicked one off for you. Will be available once the CI runs finish. |
Fixes #198
Updated the build task in
deno.json
to use the latest wasmbuild. Builds successfully and tests pass locally.