Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[issue-117] Unzip #122

Merged
merged 17 commits into from
May 29, 2020
Merged

[issue-117] Unzip #122

merged 17 commits into from
May 29, 2020

Conversation

hardy613
Copy link
Contributor

@hardy613 hardy613 commented May 17, 2020 •
edited
Loading

Description

Add unzip requirement to known issues in readme and add check for unzip in install file

we also moved all program checks at the start of the file, thanks @MarkTiedemann for reviews and suggestions!

Issue

#117

MarkTiedemann
MarkTiedemann reviewed May 17, 2020
View reviewed changes
README.md Outdated Show resolved Hide resolved
@MarkTiedemann
Copy link
Contributor

@hardy613 I think it would be good to give some more details as well.

For example, the other known issue, "Running scripts is disabled", (1) shows the output of a failed command, (2) answers the question "When does this issue occur?", and (3) answers the question "How can this issue be fixed?".

@hardy613
Copy link
Contributor Author

Sounds good

MarkTiedemann
MarkTiedemann reviewed May 17, 2020
View reviewed changes
README.md Outdated Show resolved Hide resolved
MarkTiedemann
MarkTiedemann reviewed May 17, 2020
View reviewed changes
README.md Outdated Show resolved Hide resolved
MarkTiedemann
MarkTiedemann reviewed May 17, 2020
View reviewed changes
README.md Outdated Show resolved Hide resolved
MarkTiedemann
MarkTiedemann reviewed May 17, 2020
View reviewed changes
README.md Outdated Show resolved Hide resolved
@MarkTiedemann MarkTiedemann mentioned this pull request May 17, 2020
Merged
@MarkTiedemann
Copy link
Contributor

LGTM.

cc @ry

@MarkTiedemann MarkTiedemann mentioned this pull request May 18, 2020
Closed
@MarkTiedemann MarkTiedemann mentioned this pull request May 29, 2020
Closed
@bartlomieju
Copy link
Member

@MarkTiedemann are you still ok with these changes?

@MarkTiedemann
Copy link
Contributor

@bartlomieju This PR currently re-adds the "Running scripts is disabled" known issue, which I think may be a merging error.

I also think that the following check is not necessary since the script was, most likely, already downloaded using curl:

if ! command -v curl >/dev/null; then
	echo "Error: curl is required to install Deno." 1>&2
	exit 1
fi

But I think, if those two issues are fixed, it should be merged, yes.

@bartlomieju
Copy link
Member

@bartlomieju This PR currently re-adds the "Running scripts is disabled" known issue, which I think may be a merging error.

I'm a bit lost, can you mark this bit in a diff?

MarkTiedemann
MarkTiedemann reviewed May 29, 2020
View reviewed changes
README.md Outdated Show resolved Hide resolved
@bartlomieju
Copy link
Member

Thank you @hardy613!

@bartlomieju bartlomieju merged commit 2efb5f0 into denoland:master May 29, 2020
@hardy613
Copy link
Contributor Author

Amazing, thanks everyone!

@hardy613 hardy613 deleted the iss-117 branch May 29, 2020 11:36
justjavac added a commit to denocn/deno_install that referenced this pull request Jun 5, 2020
@justjavac
Squashed commit of the following:
af34cde 
commit 63a4971
Author: Mark Tiedemann <www.marktiedemann@gmail.com>
Date:   Tue Jun 2 22:47:11 2020 +0200

    Support unzipping on Windows 8.1 (denoland#147)

    Fixes: denoland#146

commit 8ef397d
Author: Mark Tiedemann <www.marktiedemann@gmail.com>
Date:   Tue Jun 2 22:12:19 2020 +0200

    Fix old PS temp file installation (denoland#145)

commit 0335797
Author: Mark Tiedemann <www.marktiedemann@gmail.com>
Date:   Mon Jun 1 15:31:39 2020 +0200

    Remove redundant 'v' in PowerShell installer (denoland#143)

commit 42f7235
Author: Mark Tiedemann <www.marktiedemann@gmail.com>
Date:   Sun May 31 14:04:29 2020 +0200

    Print unexpanded variables (denoland#142)

commit c92645c
Author: Bartek Iwańczuk <biwanczuk@gmail.com>
Date:   Sun May 31 12:11:48 2020 +0200

    fix bad quotation (denoland#141)

commit 73ac1a8
Author: jremi <jeremy.bursky@gmail.com>
Date:   Sun May 31 02:54:30 2020 -0700

    Installer messaging update on the post install.sh default shell profile filename path (denoland#92)

commit af964a0
Author: Mark Tiedemann <www.marktiedemann@gmail.com>
Date:   Sun May 31 11:53:42 2020 +0200

    Remove duplicate arch check (Fixes denoland#139) (denoland#140)

commit 6272499
Author: Yamboy1 <yamboyd1@gmail.com>
Date:   Fri May 29 23:44:01 2020 +1200

    Add deno-bin (denoland#137)

commit a6b3b7d
Author: Mark Tiedemann <www.marktiedemann@gmail.com>
Date:   Fri May 29 13:35:47 2020 +0200

    Update specific version from 0.38.0 to 1.0.0 (denoland#135)

commit 7995d43
Author: Mark Tiedemann <www.marktiedemann@gmail.com>
Date:   Fri May 29 13:35:21 2020 +0200

    Clean-up left-over known issue in readme (denoland#136)

commit 2efb5f0
Author: Scott Hardy <hardy613@users.noreply.github.com>
Date:   Fri May 29 07:29:55 2020 -0400

    fix: issue with unzip (denoland#122)

commit 0668841
Author: Mark Tiedemann <www.marktiedemann@gmail.com>
Date:   Fri May 29 12:36:57 2020 +0200

    Remove temp file from PS install command; Remove PS linting (denoland#133)

commit 5d62b56
Author: Mark Tiedemann <www.marktiedemann@gmail.com>
Date:   Fri May 29 00:43:28 2020 +0200

    Fix PowerShell usage in CI (denoland#134)

commit bf88be1
Author: Jonas Tranberg <naueramant@users.noreply.github.com>
Date:   Fri May 29 00:28:41 2020 +0200

    Added install instructions for Arch Linux (denoland#128)

commit f9cabf1
Author: Mark Tiedemann <www.marktiedemann@gmail.com>
Date:   Fri May 29 00:26:42 2020 +0200

    Test both pwsh and powershell (denoland#120)

commit e225f8e
Author: Manu <manu.elayath@gmail.com>
Date:   Fri May 29 03:54:49 2020 +0530

    Update #install_specific_version of README to version 1.0.0 (denoland#119)

commit cdd686a
Author: Mark Tiedemann <www.marktiedemann@gmail.com>
Date:   Thu May 28 23:57:56 2020 +0200

    Re-enable sh lint (denoland#121)

commit 2a6d256
Merge: bd28456 79c0e20
Author: Bartek Iwańczuk <biwanczuk@gmail.com>
Date:   Thu May 28 23:49:07 2020 +0200

    Cleanup Windows installation scripts

commit 79c0e20
Author: Mark Tiedemann <www.marktiedemann@gmail.com>
Date:   Sun May 17 18:58:30 2020 +0200

    Clean-up install_test.ps1

commit 88bb1e5
Author: Mark Tiedemann <www.marktiedemann@gmail.com>
Date:   Sun May 17 16:19:53 2020 +0200

    Misc cleanup
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarkTiedemann MarkTiedemann MarkTiedemann left review comments

@bartlomieju bartlomieju bartlomieju approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hardy613 @MarkTiedemann @bartlomieju