Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

explicit-module-boundary-types and JavaScript files #1049

Closed
Conaclos opened this issue May 20, 2022 · 0 comments · Fixed by #1050
Closed

explicit-module-boundary-types and JavaScript files #1049

Conaclos opened this issue May 20, 2022 · 0 comments · Fixed by #1050
Labels
bug Something isn't working

Comments

@Conaclos
Copy link
Contributor

Hi!

Lint Name

explicit-module-boundary-types

Code Snippet

export function f() {}
{
  "lint": {
    "files": {
      "include": ["src/"]
    },
    "rules": {
      "tags": ["recommended"],
      "include": ["explicit-module-boundary-types"]
    }
  }
}

Expected Result

The rule should not be applied on JavaScript files.

Actual Result

export function f() {}
       ^^^^^^^^^^^^^^^
    src/index.js:1:7

    hint: Add a return type to the function signature
    help: for further information visit https://lint.deno.land/#explicit-function-return-type

Additional Info

Version

deno 1.21.3 (release, x86_64-unknown-linux-gnu)
v8 10.0.139.17
typescript 4.6.2

I also tested with @node-rs/denolint 1.13.1 (release, x86_64-unknown-linux-gnu)
(The previous diagnostic comes from there)

@Conaclos Conaclos added the bug Something isn't working label May 20, 2022
Conaclos added a commit to bare-ts/bare that referenced this issue May 20, 2022
Note that we also lint tests-corpus to ensure that
bare-ts generates high-quality codes.

For now, we do not use the config file because
it does not take into account the field `files`.
I opened an issue for that:

  napi-rs/node-rs#635

I added a config files for deno lint command.
This allows to manually check extra rules:

  deno lint --config .deno.json

Note that some rules are violated.
I excluded scripts and tests-corpus to avoid excessive rule vilation.
These two problems come from bugs that are reported:

  denoland/deno_lint#1018
  denoland/deno_lint#1048
  denoland/deno_lint#1049
Conaclos added a commit to bare-ts/bare that referenced this issue May 24, 2022
Note that we also lint tests-corpus to ensure that
bare-ts generates high-quality codes.

For now, we do not use the config file because
it does not take into account the field `files`.
I opened an issue for that:

  napi-rs/node-rs#635

I added a config files for deno lint command.
This allows to manually check extra rules:

  deno lint --config .deno.json

Note that some rules are violated.
I excluded scripts and tests-corpus to avoid excessive rule vilation.
These two problems come from bugs that are reported:

  denoland/deno_lint#1018
  denoland/deno_lint#1048
  denoland/deno_lint#1049
Conaclos added a commit to bare-ts/bare that referenced this issue May 24, 2022
Note that we also lint tests-corpus to ensure that
bare-ts generates high-quality codes.

For now, we do not use the config file because
it does not take into account the field `files`.
I opened an issue for that:

  napi-rs/node-rs#635

I added a config files for deno lint command.
This allows to manually check extra rules:

  deno lint --config .deno.json

Note that some rules are violated.
I excluded scripts and tests-corpus to avoid excessive rule vilation.
These two problems come from bugs that are reported:

  denoland/deno_lint#1018
  denoland/deno_lint#1048
  denoland/deno_lint#1049
Conaclos added a commit to bare-ts/bare that referenced this issue May 24, 2022
Note that we also lint tests-corpus to ensure that
bare-ts generates high-quality codes.

For now, we do not use the config file because
it does not take into account the field `files`.
I opened an issue for that:

  napi-rs/node-rs#635

I added a config files for deno lint command.
This allows to manually check extra rules:

  deno lint --config .deno.json

Note that some rules are violated.
I excluded scripts and tests-corpus to avoid excessive rule vilation.
These two problems come from bugs that are reported:

  denoland/deno_lint#1018
  denoland/deno_lint#1048
  denoland/deno_lint#1049
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant