Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: resolve a version requirement to the latest dist tag if it matches #37

Merged
merged 7 commits into from Oct 3, 2023
Merged

fix: resolve a version requirement to the latest dist tag if it matches #37

merged 7 commits into from Oct 3, 2023

Conversation

rnbguy
Copy link
Contributor

@rnbguy rnbguy commented Sep 23, 2023

Closes #36

Adds logic to return the latest tagged version if it is present and satisfies the version requirement.

@dsherret dsherret self-requested a review September 25, 2023 15:12
dsherret
dsherret approved these changes Oct 3, 2023
View reviewed changes
Copy link
Member

@dsherret dsherret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for looking into this and providing the fix!

(Side note: in the future I'd recommend opening PRs from a different branch other than your main branch so that I can push minor adjustments. I will open a separate PR with a few changes instead)

@dsherret dsherret changed the title fix: inconsistent npm package resolution fix: resolve a version requirement to the latest dist tag if it matches Oct 3, 2023
@dsherret dsherret merged commit 6f350bd into denoland:main Oct 3, 2023
1 check passed
This was referenced Oct 3, 2023
Merged
Merged
dsherret added a commit to denoland/deno that referenced this pull request Oct 3, 2023
@dsherret
fix(npm): upgrade to deno_npm 0.15.2 (#20772)
54fcf53 
* fix: handle optional deps not found in dependencies map
(denoland/deno_npm#38)
* fix: resolve a version requirement to the latest dist tag if it
matches (denoland/deno_npm#37)

Closes #20771
bartlomieju pushed a commit to denoland/deno that referenced this pull request Oct 12, 2023
@dsherret @bartlomieju
fix(npm): upgrade to deno_npm 0.15.2 (#20772)
eae70d3 
* fix: handle optional deps not found in dependencies map
(denoland/deno_npm#38)
* fix: resolve a version requirement to the latest dist tag if it
matches (denoland/deno_npm#37)

Closes #20771
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsherret dsherret dsherret approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

inconsistent npm version resolution
2 participants
@rnbguy @dsherret