Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handle optional deps not found in dependencies map #38

Merged

Conversation

dsherret
Copy link
Member

@dsherret dsherret commented Oct 3, 2023

Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dsherret dsherret merged commit 00fc074 into denoland:main Oct 3, 2023
1 check passed
@dsherret dsherret deleted the fix_optional_deps_not_in_deps_list branch October 3, 2023 16:23
dsherret added a commit to denoland/deno that referenced this pull request Oct 3, 2023
* fix: handle optional deps not found in dependencies map
(denoland/deno_npm#38)
* fix: resolve a version requirement to the latest dist tag if it
matches (denoland/deno_npm#37)

Closes #20771
bartlomieju pushed a commit to denoland/deno that referenced this pull request Oct 12, 2023
* fix: handle optional deps not found in dependencies map
(denoland/deno_npm#38)
* fix: resolve a version requirement to the latest dist tag if it
matches (denoland/deno_npm#37)

Closes #20771
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants