Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: better handling of multiple optional peer dependencies #9

Merged

Conversation

dsherret
Copy link
Member

@dsherret dsherret commented May 24, 2023

This was accidentally doing stuff like the following (note all the axios dependencies for the optional dependencies):

    "dependencies": {
          "@anthropic-ai/sdk": "@anthropic-ai/sdk@0.4.3",
          "@aws-sdk/client-dynamodb": "axios@1.4.0",
          "@aws-sdk/client-lambda": "axios@1.4.0",
          "@aws-sdk/client-s3": "axios@1.4.0",
          "@aws-sdk/client-sagemaker-runtime": "axios@1.4.0",
          "@clickhouse/client": "axios@1.4.0",
          "@getmetal/metal-sdk": "axios@1.4.0",
          "@huggingface/inference": "axios@1.4.0",
          "@opensearch-project/opensearch": "axios@1.4.0",
          "@pinecone-database/pinecone": "axios@1.4.0",
          "@supabase/supabase-js": "axios@1.4.0",
          "@tensorflow-models/universal-sentence-encoder": "axios@1.4.0",
          "@tensorflow/tfjs-converter": "axios@1.4.0",
          "@tensorflow/tfjs-core": "axios@1.4.0",
          "@zilliz/milvus2-sdk-node": "axios@1.4.0",
          "ansi-styles": "ansi-styles@5.2.0",
          "apify-client": "axios@1.4.0",
          "axios": "axios@1.4.0",

@dsherret dsherret requested a review from bartlomieju May 24, 2023 01:42
@dsherret dsherret merged commit 7ee6946 into denoland:main May 24, 2023
@dsherret dsherret deleted the fix_handle_multiple_optional_peer_deps branch May 24, 2023 01:46
dsherret added a commit to denoland/deno that referenced this pull request May 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants