Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace remaining "deno" module usages with Deno global var #247

Merged
merged 1 commit into from Mar 8, 2019
Merged

Replace remaining "deno" module usages with Deno global var #247

merged 1 commit into from Mar 8, 2019

Conversation

kt3k
Copy link
Member

@kt3k kt3k commented Mar 7, 2019

'deno' builtin module is going to be removed soon ( denoland/deno#1895 ). This PR replace those usages with Deno global variable.

@ry ry mentioned this pull request Mar 8, 2019
Merged
ry
ry approved these changes Mar 8, 2019
View reviewed changes
Copy link
Member

@ry ry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks @kt3k : )

@ry ry merged commit 3953929 into denoland:master Mar 8, 2019
@kt3k kt3k deleted the feature/module-to-global-var branch March 8, 2019 03:21
ry pushed a commit to ry/deno that referenced this pull request Oct 9, 2019
@kt3k @ry
Use Deno global var instead of built-in "deno" module (denoland/deno_…
f90f62f 
…std#247)

Original: denoland/deno_std@3953929
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ry ry ry approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kt3k @ry