-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove 'deno' builtin module #1895
Conversation
99ee986
to
60c07a9
Compare
@kitsonk I'm still seeing Deno stuff twice in
|
@ry Oops. Yeah. That was the other change I forgot. Will fix in a little bit. |
@ry the build failure (https://travis-ci.com/denoland/deno/jobs/183238342#L1796) looks like some sort of intermittent CI stability issue versus a problem with this patch. |
@kitsonk from just above that in the build log -
|
cool... all clear now |
@kitsonk PTAL I've added a commit to remove the builtin logic from libdeno as well |
@ry LGTM... I thought about doing that as well, but thought it was an ok feature that might be needed in the future, but that really seems unlikely, as if we decided the |
@kitsonk I hesitated too - but I think we should remove now because
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There has been a breaking API change in Deno v.0.3.3 that also breaks this module. The import of "deno" module got replaced with a global Deno variable. The "deno" module removal PR: denoland/deno#1895 Release notes of v.0.3.3: denoland/deno@3dbb06e#diff-30ebd105aef11de730b7b473a247e99bR16
BREAKING CHANGE
This PR removes the builtin module
"deno"
. Only the use of the namespace ofDeno
is supported.