Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(node): support mapping Node flags to Deno #2688

Merged
merged 2 commits into from Sep 27, 2022
Merged

Conversation

cjihrig
Copy link
Contributor

@cjihrig cjihrig commented Sep 22, 2022

This commit adds initial support for mapping Node CLI flags to Deno CLI flags. This is done to better support the case where Node compat mode is used to spawn another Node subprocess (that is actually Deno in compat mode - not at all confusing).

Refs: #2674

Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! LGTM 👍

This commit adds initial support for mapping Node CLI flags to
Deno CLI flags. This is done to better support the case where
Node compat mode is used to spawn another Node subprocess (that
is actually Deno in compat mode - not at all confusing).

Refs: denoland#2674
@cjihrig cjihrig merged commit 9db29fa into denoland:main Sep 27, 2022
@cjihrig cjihrig deleted the arg-map branch September 27, 2022 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants