Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(node): add child_process.execSync() #2689

Merged
merged 4 commits into from Sep 24, 2022
Merged

feat(node): add child_process.execSync() #2689

merged 4 commits into from Sep 24, 2022

Conversation

cjihrig
Copy link
Contributor

@cjihrig cjihrig commented Sep 22, 2022 •
edited

This PR adds child_process.execSync().

Refs: #2631

@CLAassistant
Copy link

CLAassistant commented Sep 22, 2022 •
edited

CLA assistant check
All committers have signed the CLA.

@cjihrig cjihrig marked this pull request as draft September 22, 2022 21:48
@cjihrig
nope. test doesn't work on windows
f8d1f95 
i think this is a deno issue
@cjihrig cjihrig mentioned this pull request Sep 23, 2022
Closed
@cjihrig cjihrig marked this pull request as ready for review September 23, 2022 21:55
kt3k
kt3k approved these changes Sep 24, 2022
View reviewed changes
Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Nice work!

@cjihrig cjihrig merged commit 2fb18b3 into denoland:main Sep 24, 2022
@cjihrig cjihrig deleted the exec-sync branch September 24, 2022 13:12
@iuioiua iuioiua mentioned this pull request Sep 26, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kt3k kt3k kt3k approved these changes

@bartlomieju bartlomieju Awaiting requested review from bartlomieju

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@cjihrig @CLAassistant @kt3k