Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tracking issue: Node 18 compat layer updates #2631

Closed
cjihrig opened this issue Sep 7, 2022 · 2 comments
Closed

Tracking issue: Node 18 compat layer updates #2631

cjihrig opened this issue Sep 7, 2022 · 2 comments
Assignees
Labels
node Related to node compatibility layer

Comments

@cjihrig
Copy link
Contributor

cjihrig commented Sep 7, 2022

This issue is about updating the Node compatibility layer test suite to Node 18 as it enters LTS in October 2022.

I have discussed this plan offline with @bartlomieju. The plan is to merge #2585, with test-fs-rm.js and test-webcrypto-sign-verify.js not updated (so they pass). Then we can work on adding the missing APIs.

@cjihrig cjihrig added the node Related to node compatibility layer label Sep 7, 2022
@cjihrig cjihrig self-assigned this Sep 7, 2022
cjihrig added a commit that referenced this issue Sep 8, 2022
The rest of the update can be tracked in
#2631
cjihrig added a commit to cjihrig/deno_std that referenced this issue Sep 22, 2022
cjihrig added a commit to cjihrig/deno_std that referenced this issue Sep 23, 2022
@cjihrig
Copy link
Contributor Author

cjihrig commented Sep 23, 2022

child_process.execSync() is being added in #2689. Unfortunately, the test still fails on Windows in CI. I guess it's because of denoland/deno#8852, which was also noted in recent PRs that added spawnSync() and exec().

Node.js compatibility "parallel\test-fs-rm.js" => ./node/_tools/test.ts:45:8
error: AssertionError: Failed assertion: '\"git --version\"' is not recognized as an internal or external command,
operable program or batch file.
'\"git init\"' is not recognized as an internal or external command,
operable program or batch file.
'\"git init\"' is not recognized as an internal or external command,
operable program or batch file.
'\"git init\"' is not recognized as an internal or external command,
operable program or batch file.
The filename, directory name, or volume label syntax is incorrect.
'\"icacls C:\actions-runner\work\deno_std\deno_std\node\_tools\test\.tmp.0\rm-10 /remove:d \"everyone\"\"' is not recognized as an internal or external command,
operable program or batch file.

cjihrig added a commit that referenced this issue Sep 24, 2022
cjihrig added a commit to cjihrig/deno that referenced this issue Sep 30, 2022
When storing public and private keys in the key store, use
a different handle for each key so that they can be looked up
in the future.

Refs: denoland#14119
Refs: denoland/deno_std#2631
cjihrig added a commit to denoland/deno that referenced this issue Sep 30, 2022
When storing public and private keys in the key store, use a different
handle for each key so that they can be looked up in the future.

Refs: #14119
Refs: denoland/deno_std#2631
@kt3k
Copy link
Member

kt3k commented Nov 11, 2022

Done in #2585 and #2814

Thanks @cjihrig !

@kt3k kt3k closed this as completed Nov 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
node Related to node compatibility layer
Projects
None yet
Development

No branches or pull requests

2 participants