-
Notifications
You must be signed in to change notification settings - Fork 602
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Toml support #300
Toml support #300
Conversation
@zekth re: |
@zekth regarding your question - are there any existing libraries we can examine to copy behavior from? |
@zekth And how do they act on invalid declaration? |
@ry directly throws exception. It was just an idea i had. |
@ry you put it as ready for review, there is still a remaining type handling left. I'm working on it and on some speed optimisations. Do you want to merge it in this state or wait for the last type to be handled? No problem for me in both cases. |
@zekth I'm ok with merging now - looks useful as it is - but please complete that in follow up PRs |
@ry ready to ship. Array of tables is handled now, also updated the doc for the warning. I'll do some optimisation in future PRs to fix the speed and remaining cases. |
Can you copy https://github.com/denoland/deno/blob/master/Cargo.toml to |
@ry Ready to merge. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work! This is great to have.
LGTM
As told in #232 here is a draft of the TOML parser.
Added the documentation for the module.
Also the handling of
Array Of Tables
is not finished yet.Questions:
strict
could be added to handle both cases.Note: @GrosSacASac
deepAssign
function has been added toutil/deep_assign.ts
TOML specs