Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(io): deprecate types.d.ts #3017

Closed
wants to merge 2 commits into from
Closed

refactor(io): deprecate types.d.ts #3017

wants to merge 2 commits into from

Conversation

iuioiua
Copy link
Collaborator

@iuioiua iuioiua commented Dec 19, 2022

Reader, ReaderSync, Writer and WriterSync interfaces are now supported in Deploy.

FYI types.d.ts was added in #912, in May 2021.

@ayame113
Copy link
Contributor

I thought this was part of the work being done on denoland/deno#9795, as #912 (comment) says. maybe we don't need to remove this? (sorry if i'm wrong)

@iuioiua
Copy link
Collaborator Author

iuioiua commented Dec 19, 2022

Hm... Perhaps, the opposite should be done. Instead of removing types.d.ts, it should be extended, so all Deno.Reader/Deno.Writer instances are replaced with these generic types.

There may be reasons to either entirely deprecate this file or fully adapt it throughout the rest of the repo.

Thoughts?

@iuioiua iuioiua marked this pull request as ready for review December 19, 2022 01:17
@iuioiua iuioiua requested a review from kt3k as a code owner December 19, 2022 01:17
@kt3k
Copy link
Member

kt3k commented Dec 19, 2022

I'm in favor of the opposite of this PR. As @ayame113 points, we're deprecating and removing Deno.Reader etc in the future. These types in io/types.d.ts should be used everywhere in std instead of Deno.Reader etc.

@iuioiua
Copy link
Collaborator Author

iuioiua commented Dec 20, 2022

Another benefit would be gaining web compatibility in some areas, as long as users implement their own Reader/Writer classes.

@bartlomieju, WDYT? If we all agree, I'd be happy to implement it.

@bartlomieju
Copy link
Member

I'm in favor of the opposite of this PR. As @ayame113 points, we're deprecating and removing Deno.Reader etc in the future. These types in io/types.d.ts should be used everywhere in std instead of Deno.Reader etc.

I agree with that as well.

@iuioiua
Copy link
Collaborator Author

iuioiua commented Dec 20, 2022

Closing in favour of #3030.

@iuioiua iuioiua closed this Dec 20, 2022
@iuioiua iuioiua deleted the deprecate-io-types branch December 20, 2022 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants