Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove: Deno namespace IO types #3030

Merged
merged 5 commits into from Dec 23, 2022
Merged

remove: Deno namespace IO types #3030

merged 5 commits into from Dec 23, 2022

Conversation

iuioiua
Copy link
Collaborator

@iuioiua iuioiua commented Dec 20, 2022 •
edited

Deno is moving more towards the Stream API. This change removes the following Deno namespace IO types/interfaces:

  • Deno.Reader
  • Deno.Writer
  • Deno.ReaderSync
  • Deno.WriterSync
  • Deno.Closer

Related:

@iuioiua iuioiua changed the title removed: Deno namespace IO types remove: Deno namespace IO types Dec 20, 2022
@iuioiua iuioiua mentioned this pull request Dec 20, 2022
Closed
@iuioiua iuioiua marked this pull request as ready for review December 20, 2022 21:59
@lino-levan
Copy link
Contributor

This is a pretty large PR, we should be careful about not creating any regressions but looks like good work to me.

@kt3k
Copy link
Member

kt3k commented Dec 21, 2022 •
edited

My main concern: was this migration needed for Deno.Seeker and Deno.SeekerSync?

Let's work on them in later PRs. I think we first need to discuss about them in denoland/deno repo.

kt3k
kt3k reviewed Dec 21, 2022
View reviewed changes
README.md Outdated Show resolved Hide resolved
@kt3k kt3k mentioned this pull request Dec 21, 2022
Closed
kt3k
kt3k approved these changes Dec 22, 2022
View reviewed changes
Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kt3k kt3k mentioned this pull request Dec 22, 2022
Open
13 tasks
@kt3k kt3k merged commit 2f9baf6 into denoland:main Dec 23, 2022
@iuioiua iuioiua deleted the types branch December 23, 2022 05:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kt3k kt3k kt3k approved these changes

@crowlKats crowlKats Awaiting requested review from crowlKats crowlKats is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@iuioiua @lino-levan @kt3k