Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BREAKING(streams): remove readable_stream_from_iterable #3579

Merged
merged 3 commits into from
Aug 28, 2023

Conversation

lino-levan
Copy link
Contributor

Failing CI in #3578

Copy link
Collaborator

@iuioiua iuioiua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@kt3k kt3k merged commit 8043078 into denoland:main Aug 28, 2023
9 checks passed
@jollytoad
Copy link
Contributor

jollytoad commented Aug 31, 2023

This is sad news, any chance we can keep this?
Please see my comment... #3484 (comment)

Although, it's not the end of the world, I guess I can pin to the old version or take a copy, but it would be generally nice if 'polyfill' solutions could remain until the web APIs are commonly implemented.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants