BREAKING(collections): deprecate groupBy()
#3663
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Related to #3594. |
iuioiua
requested changes
Nov 2, 2023
iuioiua
approved these changes
Nov 2, 2023
|
Deprecation makes sense to me, but safari still doesn't support this according to MDN https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Object/groupBy I'm afraid we might get similar reaction to the case of |
|
Not sure about this. I'm still considering |
|
We updated the deprecation policy in #3807 Now we recommend the users to pin the URL to the old std version if they still need them. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
groupBycan be replaced byObject.groupByin Deno 1.37. Creating this as a draft for now because the TypeScript lib isn't updated, but running this without typechecking passes fine.