Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(assert): improve assertion message of assertNotStrictEquals() #3820

Merged
merged 2 commits into from
Nov 20, 2023

Conversation

hukuuu
Copy link
Contributor

@hukuuu hukuuu commented Nov 19, 2023

As pointed out in #3816, this is more user friendly and less confusing message

@hukuuu hukuuu requested a review from kt3k as a code owner November 19, 2023 21:23
@CLAassistant
Copy link

CLAassistant commented Nov 19, 2023

CLA assistant check
All committers have signed the CLA.

@iuioiua iuioiua changed the title feat(assert) improve assertion message of assertNotStrictEquals feat(assert): improve assertion message of assertNotStrictEquals() Nov 19, 2023
Copy link
Collaborator

@iuioiua iuioiua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks! Please sign the CLA so I may merge.

@iuioiua iuioiua merged commit 998fb62 into denoland:main Nov 20, 2023
10 checks passed
@iuioiua iuioiua changed the title feat(assert): improve assertion message of assertNotStrictEquals() fix(assert): improve assertion message of assertNotStrictEquals() Nov 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants