Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

assertNotStrictEquals() throws with an incorrect error message #3816

Closed
jespertheend opened this issue Nov 17, 2023 · 3 comments
Closed

assertNotStrictEquals() throws with an incorrect error message #3816

jespertheend opened this issue Nov 17, 2023 · 3 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@jespertheend
Copy link
Contributor

jespertheend commented Nov 17, 2023

Describe the bug

assertNotStrictEquals() throws with an incorrect message I believe.
I think it is supposed to say 'expected not to be' instead of 'expected to be'.

Steps to Reproduce

import {assertNotStrictEquals} from "https://deno.land/std@0.207.0/assert/mod.ts";

const a = {};
assertNotStrictEquals(a, a);

Expected behavior

Error message says 'Expected "actual" not to be strictly unequal to: {}.'

Environment

  • OS: MacOS 14.0 (23A344)
  • deno version: 1.38.1
  • std version: 0.207.0
@jespertheend jespertheend added bug Something isn't working needs triage labels Nov 17, 2023
@iuioiua
Copy link
Contributor

iuioiua commented Nov 18, 2023

The error message says Expected "actual" to be strictly unequal to..., which is correct. However, it could be worded better. Something like Expected "actual" to not be strictly equal to...

@iuioiua iuioiua added good first issue Good for newcomers enhancement New feature or request and removed bug Something isn't working needs triage labels Nov 18, 2023
@jespertheend
Copy link
Contributor Author

Oh hah! Didn't even notice the use of 'unequal' there 😅

@iuioiua
Copy link
Contributor

iuioiua commented Nov 18, 2023

Understandable... it's hiding in there 👀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants