Test runner v2 #604
Merged
Test runner v2 #604
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@nayeemrmn can you update the tests to present the new behavior of match? Also, I'm still convinced we should fail test run if no matching files are found (surely, a flag to disable this behavior can be added, but the default should fail), so if you could add that option as well. |
bartlomieju
requested changes
Sep 19, 2019
|
@bartlomieju @lucacasonato I suggest landing #599 first. |
nayeemrmn
force-pushed
the
test-runner
branch
from
7b83407
to
77feacc
Compare
nayeemrmn
force-pushed
the
test-runner
branch
from
2237ce5
to
d00887e
Compare
nayeemrmn
force-pushed
the
test-runner
branch
2 times, most recently
from
40bd039
to
6bacb5f
Compare
|
@bartlomieju I think this is ready. Could I get another review? cc @ry |
|
Is there a specific reason for having |
@sholladay When the number of tests is dynamic somehow, or someone wants their infrastructure up before they have any tests? Maybe that's contrived 😅 While it makes sense practically, I just think that failing when no tests are run is 'illogical' enough that there should be a way of at least overriding it. |
bartlomieju
reviewed
Sep 22, 2019
nayeemrmn
force-pushed
the
test-runner
branch
12 times, most recently
from
7567f35
to
a494bec
Compare
nayeemrmn
force-pushed
the
test-runner
branch
from
2db63ca
to
6c1b4bf
Compare
nayeemrmn
force-pushed
the
test-runner
branch
from
6c1b4bf
to
31204c9
Compare
|
@ry PTAL |
ry
reviewed
Sep 27, 2019
ry
reviewed
Sep 27, 2019
|
Look like a nice clean up. Just a couple comments... I'll land when @bartlomieju approves. |
|
@bartlomieju Ready. |
bartlomieju
approved these changes
Sep 28, 2019
nayeemrmn
force-pushed
the
test-runner
branch
from
c9ccba0
to
bfb6423
Compare
nayeemrmn
force-pushed
the
test-runner
branch
from
bfb6423
to
b421efd
Compare
nayeemrmn
added a commit
to nayeemrmn/deno_std
that referenced
this pull request
Oct 2, 2019
fs/glob.ts: - Improve prototypes for expandGlob() and expandGlobSync() from denoland#604. - Rename glob() to globToRegExp(). - Add normalizeGlob() and joinGlobs(). - Extract GlobToRegExpOptions from GlobOptions, remove the strict and filepath options. fs/globrex.ts: - Add GlobrexOptions. fs/path/constants.ts: - Add SEP_PATTERN. fs/walk.ts: - Add WalkOptions:includeFiles - Default WalkOptions::includeDirs to true. - Don't traverse directories matching a skip pattern. - Remove walkSync()'s default root value. prettier: - Refactor to use expandGlob(). testing: - Make findTestModules() an async generator.
nayeemrmn
added a commit
to nayeemrmn/deno_std
that referenced
this pull request
Oct 2, 2019
fs/glob.ts: - Improve prototypes for expandGlob() and expandGlobSync() from denoland#604. - Rename glob() to globToRegExp(). - Add normalizeGlob() and joinGlobs(). - Extract GlobToRegExpOptions from GlobOptions, remove the strict and filepath options. fs/globrex.ts: - Add GlobrexOptions. fs/path/constants.ts: - Add SEP_PATTERN. fs/walk.ts: - Add WalkOptions::includeFiles - Default WalkOptions::includeDirs to true. - Don't traverse directories matching a skip pattern. - Remove walkSync()'s default root value. prettier: - Refactor to use expandGlob(). testing: - Make findTestModules() an async generator.
ry
pushed a commit
that referenced
this pull request
Oct 2, 2019
fs/glob.ts: - Improve prototypes for expandGlob() and expandGlobSync() from #604. - Rename glob() to globToRegExp(). - Add normalizeGlob() and joinGlobs(). - Extract GlobToRegExpOptions from GlobOptions, remove the strict and filepath options. fs/globrex.ts: - Add GlobrexOptions. fs/path/constants.ts: - Add SEP_PATTERN. fs/walk.ts: - Add WalkOptions::includeFiles - Default WalkOptions::includeDirs to true. - Don't traverse directories matching a skip pattern. - Remove walkSync()'s default root value. prettier: - Refactor to use expandGlob(). testing: - Make findTestModules() an async generator.
ry
pushed a commit
to ry/deno
that referenced
this pull request
Oct 9, 2019
ry
pushed a commit
to ry/deno
that referenced
this pull request
Oct 9, 2019
fs/glob.ts: - Improve prototypes for expandGlob() and expandGlobSync() from denoland/std#604. - Rename glob() to globToRegExp(). - Add normalizeGlob() and joinGlobs(). - Extract GlobToRegExpOptions from GlobOptions, remove the strict and filepath options. fs/globrex.ts: - Add GlobrexOptions. fs/path/constants.ts: - Add SEP_PATTERN. fs/walk.ts: - Add WalkOptions::includeFiles - Default WalkOptions::includeDirs to true. - Don't traverse directories matching a skip pattern. - Remove walkSync()'s default root value. prettier: - Refactor to use expandGlob(). testing: - Make findTestModules() an async generator. Original: denoland/std@8c90bd9
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, a directory argument will match every file in that directory which would never be useful (and the way it's implemented is the cause of denoland/deno#2948). We only get to benefit from the default globs when no arguments are given, so they have to be written out manually unless you want the exact set of files matched by just
deno test. See denoland/deno#2948 (comment).This change will make it so that any directory given as - or expanded from - an argument is interpreted as a root on which to apply the default globs. Such an API would be more ergonomic and introduce some desirable properties. See #601 (comment).
The test runner will fail by default if no tests are found. Override this with a flag.
Other API changes:
//testing/runner.ts:Add
runTestModules()andRunTestModulesOptions, renamegetMatchingUrls()tofindTestModules().//fs/mod.ts:Rename
RunOptionstoRunTestsOptions.//fs/glob.ts:Add
expandGlob(),expandGlobSync()andExpandGlobOptions. These are prototypes extracted from the test runner.//fs/path/constants.ts:Add
SEP.