feat: dprint formatter

[bartlomieju]

Closes #3818

[nayeemrmn]

Okay, the file matcher was designed like this:

• Accept a list of globs in CLI. The default should be ["."].
• Expand these globs.
  • For files that are matched, add these files to the list of matches.
  • For directories that are matched, expand some list of "default" globs rooted on each directory. This time only match files. Add these files to the list of matches.
    • For the formatter, the default globs are ["**/*"].
    • For the test runner, the default globs are ["**/?(*_)test.{js,ts}"].
    • Both have just one default glob, so unless it's trivial you can support one. But keep in mind that the patterns supported by just one glob pattern are quite limited.
• Apply exclude globs, accepted as a CSV list. Excludes must support path prefixes -- any path which has a parent which matches an exclude glob must not be included.

See denoland/deno_std#604 for the defence of this design.

[bartlomieju]

Okay, the file matcher was designed like this:

• Accept a CSV list of globs in CLI. The default should be ["."].

• Expand these globs.

  • For files that are matched, add these files to the list of matches.

  • For directories that are matched, expand some list of "default" globs rooted on each directory. This time only match files. Add these files to the list of matches.

    • For the formatter, the default globs are ["**/*"].
    • For the test runner, the default globs are ["**/?(*_)test.{js,ts}"].
    • Both use just one glob pattern, so unless it's trivial you can support one default glob. But keep in mind that the patterns supported by just one glob pattern are quite limited.

See denoland/deno_std#604 for the defence of this design.

Thanks for detailed explanation @nayeemrmn - PTAL at the PR, I added basic support for list of globs and formatter uses exact glob you specified above (though it should be limited to .tsx? and .jsx? as dprint does not support yet markdown). IIRC both formatter and test runner support ignore/exclude lists - I think I'll skip them in this PR and open an issue for that for later.

[nayeemrmn]

Edited my above comment with exclude semantics.

[nayeemrmn]

Something like:

  for path in glob_paths {
    let matches = glob::glob(&path)
      .expect("Failed to execute glob.")
      .filter_map(Result::ok);
    for match in matches {
      if is_dir(&match) {
        let secondary_matches = glob::glob(&format("{}/**/*", &match))
          .expect("Failed to execute glob.")
          .filter_map(Result::ok);
        for secondary_match in secondary_matches {
          if !is_dir(&secondary_match) {
            target_files.push(secondary_match);
          }
        }
      } else {
        target_files.push(match);
      }
    }
  }

[bartlomieju]

@nayeemrmn @ry there are two flags that are not present in this PR that are pretty useful: --stdout and --ignore-path=<FILE...>. Let's do them in follow up PR.

[ry]

LGTM