Skip to content
This repository has been archived by the owner on May 17, 2024. It is now read-only.

Highlighter Overflow #11

Closed
wants to merge 3 commits into from
Closed

Highlighter Overflow #11

wants to merge 3 commits into from

Conversation

caenguidanos
Copy link

  • Remove unnecessary sm:overflow-hidden class from highlighter to fix overflow behavior on tablet and desktop screens.
  • Remove unnecessary undefined assignation on streaming example.

lucacasonato
lucacasonato reviewed Jan 11, 2022
View reviewed changes
www/pages/[id].tsx
@@ -203,8 +203,7 @@ function SnippetComponent(props: {
</span>
)}
<div
class={tw
`px-4 py-4 text-sm overflow-scroll sm:overflow-hidden relative` +
class={tw`px-4 py-4 text-sm overflow-scroll relative` +
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing the overflow adds a bunch of scroll bars to each of the snippets. The code would probably require a larger refactor so all of the code blocks scroll in sync, with a single scroll bar at the bottom.

You can see this problem in the deployment preview.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see. Maybe the problem is the symmetric "side-to-side" code highlight system with multiple instances of a highlighter and overflow possibilities...

We can try make something more robust with one highlight code block with dynamic superpowers like stripe or stitches.

This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lucacasonato lucacasonato lucacasonato left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@caenguidanos @lucacasonato