Skip to content
This repository has been archived by the owner on May 17, 2024. It is now read-only.

Fix Forward/backward buttons break on small screens #13

Merged
merged 2 commits into from
Jan 12, 2022
Merged

Fix Forward/backward buttons break on small screens #13

merged 2 commits into from
Jan 12, 2022

Conversation

ije
Copy link
Contributor

@ije ije commented Jan 12, 2022 •
edited
Loading

close #12

Screen Shot 2022-01-12 at 20 47 55

lucacasonato
lucacasonato reviewed Jan 12, 2022
View reviewed changes
Copy link
Member

@lucacasonato lucacasonato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if it would look better if they were vertically offset on mobile. Like this

// desktop
| <-  asdasd                   asdasd  -> |

// mobile
|     fasadsas -> |
| <- asdasda      |

@ije
Copy link
Contributor Author

ije commented Jan 12, 2022

i prefer left/right structure.

@ije ije changed the title Fix Froward/backward buttons break on small screens Fix Forward/backward buttons break on small screens Jan 12, 2022
@ije
Copy link
Contributor Author

ije commented Jan 12, 2022

i just aligned forward text to right, it should look better

@ije ije merged commit aff910f into main Jan 12, 2022
@lucacasonato lucacasonato deleted the fix-nav-links-ui branch January 12, 2022 13:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lucacasonato lucacasonato lucacasonato approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Froward/backward buttons break on small screens
2 participants
@ije @lucacasonato