Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: set correct status code for non-U64 sums #33

Merged
merged 1 commit into from
Nov 14, 2023
Merged

fix: set correct status code for non-U64 sums #33

merged 1 commit into from
Nov 14, 2023

Conversation

lucacasonato
Copy link
Member

@lucacasonato lucacasonato commented Nov 13, 2023 •
edited

Fixes #32

losfair
losfair approved these changes Nov 13, 2023
View reviewed changes
Copy link
Member

@losfair losfair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lucacasonato lucacasonato merged commit e83fc48 into main Nov 14, 2023
4 checks passed
@lucacasonato lucacasonato deleted the fix_denokv_typeerrors branch November 14, 2023 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@losfair losfair losfair approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

denokv serve: 500 An internal server error occurred when attempting to sum a non kvu64
2 participants
@lucacasonato @losfair