You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
To reproduce: run denokv serve locally, connect via Deno.openKv, then attempt a sum operation on an existing non kvu64 value.
Expected:
http 4xx response, this is a non-retryable client error
Actual:
An error is logged: [ERROR denokv] Failed to write to database: Failed to perform 'sum' mutation on a non-U64 value in the database and an http 500 is returned to the client with body An internal server error occurred. The spec encourages retrying 5xx, so it's probably important to return a 4xx here instead.
The text was updated successfully, but these errors were encountered:
Upgrading to Deno 1.38.1 from 1.37.2, I see the built-in Deno.openKv('http://localhost:4512/') client will actually retry forever in this case - another reason to use 4xx here.
To reproduce: run
denokv serve
locally, connect via Deno.openKv, then attempt a sum operation on an existing non kvu64 value.Expected:
http
4xx
response, this is a non-retryable client errorActual:
An error is logged:
[ERROR denokv] Failed to write to database: Failed to perform 'sum' mutation on a non-U64 value in the database
and an http500
is returned to the client with bodyAn internal server error occurred
. The spec encourages retrying5xx
, so it's probably important to return a4xx
here instead.The text was updated successfully, but these errors were encountered: