This repository has been archived by the owner on Jun 29, 2023. It is now read-only.
refactor: switch to fresh #2016
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # components/Registry.tsx
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/denoland/deno-website2/GfRQszxL521hTBgpcS621z8vLfjk |
6 tasks
ry
reviewed
Feb 23, 2022
Comment on lines
+8
to
+25
| import "https://esm.sh/prismjs@1.25.0/components/prism-bash?no-check"; | ||
| //import "https://esm.sh/prismjs@1.25.0/components/prism-batch?no-check"; | ||
| import "https://esm.sh/prismjs@1.25.0/components/prism-css?no-check"; | ||
| //import "https://esm.sh/prismjs@1.25.0/components/prism-css-extras?no-check"; | ||
| //import "https://esm.sh/prismjs@1.25.0/components/prism-editorconfig?no-check"; | ||
| import "https://esm.sh/prismjs@1.25.0/components/prism-diff?no-check"; | ||
| //import "https://esm.sh/prismjs@1.25.0/components/prism-docker?no-check"; | ||
| //import "https://esm.sh/prismjs@1.25.0/components/prism-git?no-check"; | ||
| //import "https://esm.sh/prismjs@1.25.0/components/prism-ignore?no-check"; | ||
| import "https://esm.sh/prismjs@1.25.0/components/prism-javascript?no-check"; | ||
| //import "https://esm.sh/prismjs@1.25.0/components/prism-js-extras?no-check"; | ||
| //import "https://esm.sh/prismjs@1.25.0/components/prism-js-templates?no-check"; | ||
| //import "https://esm.sh/prismjs@1.25.0/components/prism-jsdoc?no-check"; | ||
| import "https://esm.sh/prismjs@1.25.0/components/prism-json?no-check"; | ||
| import "https://esm.sh/prismjs@1.25.0/components/prism-jsx?no-check"; | ||
| //import "https://esm.sh/prismjs@1.25.0/components/prism-markdown?no-check"; | ||
| import "https://esm.sh/prismjs@1.25.0/components/prism-rust?no-check"; | ||
| //import "https://esm.sh/prismjs@1.25.0/components/prism-toml?no-check"; |
There was a problem hiding this comment.
Some of these dont work, so will look into this on a later date
ry
reviewed
Feb 23, 2022
| @@ -45,164 +64,94 @@ export interface CodeBlockProps { | |||
| export function RawCodeBlock({ | |||
| code, | |||
| language, | |||
| className: extraClassName, | |||
| class: extraClassName, | |||
There was a problem hiding this comment.
It'd be preferable to avoid keywords like class ... is there a reason for this change?
There was a problem hiding this comment.
we declare classes with class attribute, this is just to keep in line with that
ry
reviewed
Feb 23, 2022
Comment on lines
+25
to
+38
| <meta name="twitter:card" content="summary_large_image" /> | ||
| <meta property="og:locale" content="en_US" /> | ||
| <meta property="og:site_name" content="DenoLand" /> | ||
| <meta | ||
| property="og:title" | ||
| content="Deno - A modern runtime for JavaScript and TypeScript" | ||
| /> | ||
| <meta | ||
| property="og:description" | ||
| content="Deno is a simple, modern runtime for JavaScript and | ||
| TypeScript that uses V8 and is built in Rust." | ||
| /> | ||
| <meta property="og:image" content="/images/icons/icon-512x512.png" /> | ||
| <meta property="og:type" content="website" /> |
There was a problem hiding this comment.
Not for now but I'd really like to have custom og:description for each page in the future. Current og behavior is pretty obnoxious and not very useful.
Comment on lines
+19
to
+40
| async function getVersionList(module) { | ||
| const url = \`${CDN_ENDPOINT}\${module}/meta/versions.json\`; | ||
| const res = await fetch(url, { | ||
| headers: { | ||
| accept: 'application/json', | ||
| }, | ||
| }); | ||
| if (res.status === 403 || res.status === 404) return null; | ||
| if (res.status !== 200) { | ||
| throw Error( | ||
| \`Got an error (\${res.status}) while getting the version list:\\n\${await res | ||
| .text()}\`, | ||
| ); | ||
| } | ||
|
|
||
| return await res.json(); | ||
| } | ||
|
|
||
| function updateWebhookUrl() { | ||
| const name = document.getElementById('modulename').value; | ||
| const subdir = document.getElementById('subdirectory').value; | ||
| document.getElementById('webhookURL').innerText = \`https://api.deno.land/webhook/gh/\${name}\${subdir ? ('?subdir=' + encodeURIComponent(subdir)) : ''}\`; |
There was a problem hiding this comment.
not for now, but string literals is not the ideal place to be programming... Why isn't fresh's esbuild capabilities not sufficient ?
ry
approved these changes
Feb 24, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Left to do:
module file search &manual searchbars