Skip to content
This repository has been archived by the owner on Sep 21, 2023. It is now read-only.

Fixed file streaming examples #160

Merged
merged 2 commits into from
Nov 12, 2021
Merged

Fixed file streaming examples #160

merged 2 commits into from
Nov 12, 2021

Conversation

sant123
Copy link
Contributor

@sant123 sant123 commented Nov 12, 2021

  • Fixed server hang after the first request
  • If request results in a directory, try to find a index.html file in that directory

@sant123
* Fixed server hang after the first request
575e12d 
* If request results in a directory, try to find a index.html file in that directory
@sant123 sant123 mentioned this pull request Nov 12, 2021
Merged
kt3k
kt3k approved these changes Nov 12, 2021
View reviewed changes
Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with nits

examples/file_server.md Outdated Show resolved Hide resolved
bartlomieju
bartlomieju approved these changes Nov 12, 2021
View reviewed changes
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you @sant123

@bartlomieju bartlomieju merged commit cebab1e into denoland:main Nov 12, 2021
@sant123 sant123 deleted the file_server_patch branch November 12, 2021 18:27
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kt3k kt3k kt3k approved these changes

@bartlomieju bartlomieju bartlomieju approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sant123 @kt3k @bartlomieju