Skip to content
This repository has been archived by the owner on Sep 21, 2023. It is now read-only.

Add Callbacks portion to FFI API manual #339

Merged
merged 7 commits into from
Jun 30, 2022
Merged

Add Callbacks portion to FFI API manual #339

merged 7 commits into from
Jun 30, 2022

Conversation

aapoalas
Copy link
Contributor

Relates to denoland/deno#14663

@CLAassistant
Copy link

CLAassistant commented Jun 16, 2022

CLA assistant check
All committers have signed the CLA.

runtime/ffi_api.md Outdated Show resolved Hide resolved
runtime/ffi_api.md Outdated Show resolved Hide resolved
runtime/ffi_api.md Outdated Show resolved Hide resolved
runtime/ffi_api.md Outdated Show resolved Hide resolved
Comment on lines 247 to 248
- [2] `function` type is defined as an object containing its parameters and
return value, which can be any of the supported types.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It must be passed as a pointer now. denoland/deno#14915

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't change this too much as this was about the definition, not the parameter / result types.

Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@littledivy Can you take another look?

Copy link
Member

@littledivy littledivy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@littledivy littledivy merged commit 2341ae5 into denoland:main Jun 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants