BREAKING(ext/ffi): Remove Deno.UnsafePointer indirection
#14915
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aapoalas
reviewed
Jun 20, 2022
| } else { | ||
| throw new TypeError(`Invalid FFI argument type '${type}'`); | ||
| static of(value) { | ||
| if (ObjectPrototypeIsPrototypeOf(UnsafeCallbackPrototype, value)) { |
There was a problem hiding this comment.
Supporting UnsafeCallbacks for UnsafePointer.of seems unnecessary.
There was a problem hiding this comment.
We will get rid of the UnsafePointer class completely. I was thinking that we could turn this into a more common interface until it's removed.
aapoalas
reviewed
Jun 20, 2022
|
LGTM. Did you check performance improvement? |
bartlomieju
approved these changes
Jun 20, 2022
|
Oh yeah, one thing to note publicly in the PR on this implementation is that after this there will be no difference in typing for:
So, a lot of the possible benefits of types are lost, unfortunately. |
|
yeah, I think the most notable will be for callbacks. 64bit numeric types + pointers are bigint in JS. |
aapoalas
reviewed
Jun 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commits removes the
Deno.UnsafePointerwrapper around FFI pointers. A pointer is now
represented as a bigint primitive.
There still exist the
Deno.UnsafePointer.ofAPI to get pointer value for a TypedArray and
Deno.UnsafeCallback.This commit also removes the extra processing for
FFI parameters. Hence,
Deno.UnsafeCallbackmust bepassed as a pointer.