This repository has been archived by the owner on Sep 21, 2023. It is now read-only.
Rework npm specifiers #689
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This has the advantage that we can easily display the output (and it doesn't take as much space as cowsay).
'When doing this' should come directly after the example because otherwise the reader might be confused what 'this' refers to.
"Deno application" begs the question what that is ... the term is diffuse since Deno applications can also have NPM dependencies.
More people will be looking for how to use TypeScript types than people looking for how to run NPM binaries with deno.
not-my-profile
force-pushed
the
rework-npm-specifiers
branch
from
1d451a3
to
b5ac2ff
Compare
not-my-profile
force-pushed
the
rework-npm-specifiers
branch
from
b5ac2ff
to
4eebe52
Compare
|
I did roll these changes in - thanks! https://docs.deno.com/runtime/manual/node/npm_specifiers |
|
Thanks Kevin for merging these changes ... however I am seriously displeased by you doing so without any attribution to me whatsoever. And I also think the >340 people that have contributed to this repository should continue to be attributed in the git history in the new repository. See my issue denoland/deno-docs#111. |
kwhinnery
added a commit
to denoland/deno-docs
that referenced
this pull request
Sep 18, 2023
kwhinnery
added a commit
to denoland/deno-docs
that referenced
this pull request
Sep 18, 2023
kwhinnery
added a commit
to denoland/deno-docs
that referenced
this pull request
Sep 18, 2023
This reverts commit 6616602.
kwhinnery
added a commit
to denoland/deno-docs
that referenced
this pull request
Sep 18, 2023
* Revert "revert changes from denoland/manual#689 (#116)" This reverts commit 6616602. * Revert to a33793d
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please refer to the individual commit messages for the reasoning behind the changes.
If possible please preserve the commits while merging to make the git log more readable.
The last commit introduces a new "Module resolution" section, if you want to I can split it off into a separate PR.
preview
/cc @dsherret