feat: add ArrayBuffer::was_detached() #1103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
I opened https://crbug.com/v8/13159 and https://crrev.com/c/3810345 upstream to add this as a method of |
andreubotella
added a commit
to andreubotella/rusty_v8
that referenced
this pull request
Nov 21, 2022
In denoland#1103, the `ArrayBuffer::was_detached` method was added to rusty_v8 to fill a gap in the C++ API, and it was implemented using the internal `v8::Utils::OpenHandle`. Since then, a `WasDetached` method was added to `ArrayBuffer` in V8 10.9. This PR updates the implementation to use that.
bartlomieju
pushed a commit
that referenced
this pull request
Nov 21, 2022
In #1103, the `ArrayBuffer::was_detached` method was added to rusty_v8 to fill a gap in the C++ API, and it was implemented using the internal `v8::Utils::OpenHandle`. Since then, a `WasDetached` method was added to `ArrayBuffer` in V8 10.9. This PR updates the implementation to use that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
ArrayBuffer::was_detached().While there's no
WasDetachedmethod onArrayBuffer, while going through the code I noticed there is one inJSArrayBufferViewthat we could use.Currently, Deno has no reliable way to check if an ArrayBuffer was detached. With this commit, we'll be able to make Streams and
structuredClonespec-compliant.