Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V8 escapable handle scope #113

Merged
merged 8 commits into from Dec 22, 2019
Merged

V8 escapable handle scope #113

merged 8 commits into from Dec 22, 2019

Conversation

bartlomieju
Copy link
Member

No description provided.

@bartlomieju
Copy link
Member Author

@ry I think problems with lifetimes still hold. Do you want to go ahead and land this now or shall we fix them first?

@ry
Copy link
Member

ry commented Dec 22, 2019

@bartlomieju What are the lifetime problems?

@bartlomieju
Copy link
Member Author

@ry example by Bert that should fail, but it compiles fine:

  let local: Local<v8::String>;
  {
    let scope = &mut v8::HandleScope::new(&mut locker);
    local = v8::String::new(scope, "bla").unwrap();
  }

Note that it uses HandleScope but the same rules apply to EscapableHandleScope

@bartlomieju bartlomieju merged commit 25c4f7f into denoland:master Dec 22, 2019
@bartlomieju bartlomieju deleted the v8__escapable_handle_scope branch December 22, 2019 14:05
@ry ry mentioned this pull request Dec 24, 2019
61 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants