Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add the option to disable generation from strings #1222

Merged
merged 2 commits into from
Apr 30, 2023
Merged

feat: Add the option to disable generation from strings #1222

merged 2 commits into from
Apr 30, 2023

Conversation

bakjos
Copy link
Contributor

@bakjos bakjos commented Apr 27, 2023

It also includes the IsSetGeneratorObject option

@bakjos bakjos force-pushed the bakjos/disable_code_generation branch from 3b0d821 to 6072339 Compare April 27, 2023 16:26
@bartlomieju bartlomieju self-requested a review April 27, 2023 16:36
bartlomieju
bartlomieju approved these changes Apr 30, 2023
View reviewed changes
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@bartlomieju bartlomieju merged commit 5417e2a into denoland:main Apr 30, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bartlomieju bartlomieju bartlomieju approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bakjos @bartlomieju