Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build for android #1246

Merged
merged 1 commit into from
Jul 1, 2023
Merged

Fix build for android #1246

merged 1 commit into from
Jul 1, 2023

Conversation

cions
Copy link
Contributor

@cions cions commented Jun 9, 2023

No description provided.

@CLAassistant
Copy link

CLAassistant commented Jun 9, 2023

CLA assistant check
All committers have signed the CLA.

@cions cions force-pushed the fix-android branch 2 times, most recently from e9dc5c6 to 6fb958a Compare June 22, 2023 11:39
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, @piscisaureus any comments?

Copy link
Member

@piscisaureus piscisaureus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Taknok
Copy link
Contributor

Taknok commented Jun 26, 2023

Hi,
When trying to install the v8 from the fix-android, I have the following scenari.

  1. The default install : the build.rs tries to download the *-android-*.a pre build binary from the github releases, which does not exist (yet) and fail.
  2. The built from local. I am using termux. I already have gn, ninja and clang installed.
    A. The detection of clang fails and the build.rs downloads the chromium clang. The clang downloaded is a x86_64 arch, thus the execution fails on an ARM arch.
    B. Specifying the clang base path, the compilation starts but the #include <asm/errno.h> fails as it is not presents. Creating a sym link from asm-generic to asm. Trigger the fatal error: 'asm/sigcontext.h' file not found as it is not present in the generic ASM.
    C. Along with clang path, passing to the new env var CXXSTDLIB=/data/data/com.termux/files/usr/lib/libc++_shared.so also trigger the fatal error: 'asm/sigcontext.h' file not found

Does this PR only fix for x86 android or cross build ?

@cions
Copy link
Contributor Author

cions commented Jun 28, 2023

I'm aiming for Termux on AArch64 Android.

This PR alone is not enough to build deno successfully.
See https://github.com/cions/termux-deno for build procedures.

@ry ry merged commit ca83ce5 into denoland:main Jul 1, 2023
8 checks passed
@cions cions deleted the fix-android branch July 1, 2023 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants