New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to V8 12.1.285.6 #1374
Upgrade to V8 12.1.285.6 #1374
Conversation
This reverts commit 1067a79.
Reset no longer clears exception if it was rethrown. The test had to be adjusted for the same.
I changed |
// TODO(littledivy): remove | ||
_scope: &mut HandleScope<'s, ()>, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do it in this PR?
static_assert(sizeof(v8::ScriptCompiler::Source) == | ||
align_to<size_t>(sizeof(size_t) * 9 + sizeof(int) * 2), | ||
"Source size mismatch"); | ||
static_assert(sizeof(v8::ScriptCompiler::CompilationDetails) == |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
32-bit build fails here:
../../../src/binding.cc:59:15: error: static assertion failed due to requirement 'sizeof(v8::ScriptCompiler::CompilationDetails) == sizeof(unsigned int) * 3': CompilationDetails size mismatch
59 | static_assert(sizeof(v8::ScriptCompiler::CompilationDetails) ==
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
60 | sizeof(size_t) * 3,
| ~~~~~~~~~~~~~~~~~~
../../../src/binding.cc:59:62: note: expression evaluates to '20 == 12'
59 | static_assert(sizeof(v8::ScriptCompiler::CompilationDetails) ==
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~
60 | sizeof(size_t) * 3,
| ~~~~~~~~~~~~~~~~~~
1 error generated.
example of full log here:
Changes:
v8::ScriptCompiler
size increased by 3 words withv8::ScriptCompiler::CompilationDetails
. @littledivyv8::ObjectTemplate::SetAccessor
&v8::ObjectTemplate::SetAccessorProperty
signature changed and also deprecated. @littledivyv8::Context::SetContinuationPreservedEmbedderData
deprecated. Usev8::Isolate::GetContinuationPreservedEmbedderData
instead. @littledivyGetStalledTopLevelAwaitMessage
deprecated. UseGetStalledTopLevelAwaitMessages
instead. @littledivyv8::Isolate::AttachCppHeap
deprecated. Set the heap on Isolate creation using CreateParams instead. @littledivyv8::ScriptOrigin
deprecated. Use constructor without the isolate. @bartlomiejuv8::SnapshotCreator
is deprecated. Use the version that passes CreateParams instead. @bartlomiejuv8::Isolate
assertion failures. @littledivy#1373 but without denobot force pushing over our changes :)